[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: OPP patch and new build.xml file...
David, I'm about to incorporate your changes. Here are my first
comments/questions:
- I'm not crazy about that but can we follow Suns coding conventions for Java?
The only problem with your code is that you don't write {} around one liners
after if. Again, I'm not crazy about that but would be cool.
- regarding the new build.xml: having all generated classes in a separated dir
was also possible with the old build.xml. Anyway, if you really like to use the
new Ant (295kb) instead of the old one (85kb) then I'm fine with it.
- I changed build dir to build insead of ant.build this helps me to keep my old
Makefils in sunc.
- having generated docs under the build dir looks somewhat strange to me. what
are the advantages?
- the Log4J LogWriter always prints the entire class name which makes the
output somewhat hard to read. Can we change this so that only the raw class
name is printed?
Anyway, your stuff is cool. Thanks for contributing!
Falko
On Tue, 17 Apr 2001, David Li wrote:
>
> Hi,
>
> While integrating our RDF db into the ozone source tree, we rewrite the
> build.xml file.
>
> The new build.xml requires some patch to OPP primarily to specify the
> source directory for the OPP so the generated source can be on different
> directory from the original source.
>
> The new Ant build.xml has the following features:
>
> 1. All generated files are output under ant.build directory
> ant.build/classes for compiled class
> ant.build/srcout for generated source
> ant.build/lib for generated jars
> ant.build/doc for javadocs
> ant.build/bin for script files
>
> 2. the following build options:
>
> core: ozone without xml
> main: ozone with xml
> all: fill the above bin, lib, and bin dir
> dist.bin: create a binary distribution zip of ozone
> under ant.build
> dist.src: create a source distribution zip of ozone
> under ant.build
>
> The patch has been tested for both 0.6.1 dist and current CVS. Both
> works fine.
>
> However, the Ant I am using is 1.3 and I didn't test it with the bundled
> ant.jar in Ozone. If it's not working, get ant 1.3 from
> jakarta.apache.org. ;)
>
> David Li
> DigitalSesame
>
> P.S. The attached ozone.mf is optional. If you don't want to use it,
> delete the manifest="ozone.mf" line in the build.xml.
----------------------------------------
Content-Type: application/x-gzip; name="build.xml.gz"
Content-Transfer-Encoding: base64
Content-Description:
----------------------------------------
----------------------------------------
Content-Type: application/x-gzip; name="ozone.diff.gz"
Content-Transfer-Encoding: base64
Content-Description:
----------------------------------------
----------------------------------------
Content-Type: application/x-gzip; name="ozone.mf.gz"
Content-Transfer-Encoding: base64
Content-Description:
----------------------------------------
--
______________________________________________________________________
Falko Braeutigam mailto:falko@smb-tec.com
SMB GmbH http://www.smb-tec.com